-
Notifications
You must be signed in to change notification settings - Fork 137
feat: Public Actor Permissions #2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tobice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it a quick look; it still needs a bit of love. I'd even rethink the structure a bit ;D
sources/platform/actors/development/actor_definition/input_schema/specification.md
Outdated
Show resolved
Hide resolved
| - `["READ"]` — the Actor may read from the referenced resource(s). | ||
| - `["READ", "WRITE"]` — the Actor may read and write to the referenced resource(s). | ||
|
|
||
| Notes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mention that this will be communicated to the users via the form (the tooltip).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the copy that needs to be updated. Let's not forget about updating this screenshot as well.
…y-docs into feat/public-actor-permissions
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
nmanerikar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, suggestions and corrections.
sources/platform/actors/development/permissions/migration_guide.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/permissions/migration_guide.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/permissions/migration_guide.md
Outdated
Show resolved
Hide resolved
|
Preview for this PR was built for commit |
nmanerikar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final comment, and reminder to update the screenshots.
Other than that, this looks fine.
I assume there will be a review from the content team as well?
|
|
||
|  | ||
|
|
||
| Over time, the distinction between these permission levels will become more prominent. For example, Actors requiring full permissions may display an orange badge, appear lower in Store rankings, or show extra confirmation dialogs when you run them. Whenever possible, choose Actors that use **limited permissions**. They are safer, easier to trust, and sufficient for most workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this previously, but in keeping with @TC-MO's comment about dropping mentions of future changes, we should drop this part.
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
sources/platform/actors/development/actor_definition/input_schema/specification.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/input_schema/specification.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/input_schema/specification.md
Outdated
Show resolved
Hide resolved
TC-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes are for conciness or logic flow, few comments with questions
First batch of wording, flow and consistency edits Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
…y-docs into feat/public-actor-permissions
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
Another batch of copy/flow Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
|
Preview for this PR was built for commit |
…fy-docs into feat/public-actor-permissions
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
TC-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final nits, once this all these comments are addressed we are ready for merge
sources/platform/actors/development/permissions/migration_guide.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/metamorph.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
This PR adds docs for a new platfrom feature: Actor permissions.